Bugfix for Tuya ZWT198/ZWT100-BH using _TZE204_xnbkhhdr, auto and manual are reversed in preset datapoint. #7966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Fernández <daniel@dfer.io>
Koenkk
reviewed
Sep 10, 2024
| @@ -6433,7 +6433,7 @@ const definitions: DefinitionWithExtend[] = [ | |||
| if (device.manufacturerName === '_TZE200_viy9ihs7') { | |||
| return {auto: tuya.enum(1), manual: tuya.enum(0), temporary_manual: tuya.enum(2)}; | |||
| } else { | |||
| return {manual: tuya.enum(0), auto: tuya.enum(1), temporary_manual: tuya.enum(2)}; | |||
| return {auto: tuya.enum(0), manual: tuya.enum(1), temporary_manual: tuya.enum(2)}; | |||
There was a problem hiding this comment.
I have no such device, but I guess this bug affects to both devices _TZE204_*, if someone can confirm this would be great, I think _TZE200 is the exception.
|
Makes sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I installed an Avatto wall thermostat (TS0601 _TZE204_xnbkhhdr) and I realized that auto and manual where reversed in preset datapoint in my device, checking the code I noticed that where if branches were the same.