update 3r waterleak ts #7916
Merged
update 3r waterleak ts #7916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Aug 30, 2024
| @@ -91,6 +91,18 @@ const definitions: Definition[] = [ | |||
| fromZigbee: [fz.ias_water_leak_alarm_1, fz.battery], | |||
| toZigbee: [], | |||
| ota: ota.zigbeeOTA, | |||
| extend: [ | |||
There was a problem hiding this comment.
Could you also expose these features?
There was a problem hiding this comment.
hi，we don't need this temporarily, it will be added later
There was a problem hiding this comment.
@Koenkk Can you merge it
There was a problem hiding this comment.
hi，we don't need this temporarily, it will be added later
If it's not needed, why was the cluster added?
There was a problem hiding this comment.
Sorry, I didn't explain clearly. Adding this cluster is only used on the dev console menu for the time being, and not on the expose menu.
Koenkk
reviewed
Sep 6, 2024
src/devices/third_reality.ts
Outdated
| fromZigbee: [fz.temperature, fz.humidity], | ||
| toZigbee: [], | ||
| exposes: [e.temperature(), e.humidity()], | ||
| extend: [battery({voltage: true}), forcePowerSource({powerSource: 'Battery'})], |
There was a problem hiding this comment.
Suggested change
| extend: [battery({voltage: true}), forcePowerSource({powerSource: 'Battery'})], | |
| extend: [battery({voltage: true}), forcePowerSource({powerSource: 'Battery'}), temperature(), humidity()], |
And remove exposes, fromZigbee and toZigbee
There was a problem hiding this comment.
It has been modified. Please check it again.，thanks
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.