feat: refactor develcoSpecificAirQuality into manuSpecificDevelcoAirQuality #7706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjorge
commented
Jun 29, 2024
This comment was marked as resolved.
This comment was marked as resolved.
sjorge
force-pushed
the
develcoCluster
branch
2 times, most recently
from
52a7e84 to
406888e
Compare
|
Going to test this a bit more and then mark ready, there is some more cleanup that can be done but I'm trying to work out how to best do it. I think some of these can be a more generic, like a lot of them are ignoring certain bogus values. Which can probably be added in the generic modernExtend as it could be useful for other devices. I'll need to think about this some more. |
…uality - move develcoSpecificAirQuality from zh into zhc - rename develcoSpecificAirQuality -> manuSpecificDevelcoAirQuality to be inline with other naming - start a src/lib/develco to hold the modernExtends
sjorge
commented
Jun 29, 2024
|
@Koenkk Dit kan al gemerged worden, de commits waar ik het in discord over heb waar ik nog tegen problemen loop zitten hier niet bij. En dit moet daar niet op wachten. |
|
Bedankt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup some of the develco stuff:
Merge before Koenkk/zigbee-herdsman#1097