Use 2.1-3V range for Third Reality 3RSS008Z switches #7682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This device was previously shown at 26%. With this change, they came in at 8%, and my battery tester showed them at 10% (it only does 10% increments). These were two NiMH batteries, so I think it's safe to say that the existing reporting of 26% was certainly too high. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches what ZHA does at https://github.com/zigpy/zha-device-handlers/blob/9df7c3bdd7b37f46cf6e269cec2032aedde698c1/zhaquirks/thirdreality/switch.py#L22.
While the PR at zigpy/zha-device-handlers#208 doesn't say so, I think someone must have tested to get these numbers as ZHA overrides their defaults for it while we are currently just using ours.