Omit battery_low for models that don't have it #7677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The devices in this PR don't seem to actually ever send a battery alarm. I've only ever seen them report "normal" in z2m. I've been running a sniffer for 24 hours and
zbee_zcl_general.power_config.attr_id > 0x0021shows no results. If I'm reading https://github.com/Koenkk/zigbee-herdsman/blob/73162478f5e5c3d9058bfada27dfff52b9d2c612/src/zspec/zcl/definition/cluster.ts#L71 right, if reported it should be reported with attribute ID0x3E.Also, I've never had this value flip before a battery dies, so I don't think it is just waiting for a failure state to send.