Add tuya bsd plug #6731
Merged
Add tuya bsd plug #6731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the |
|
Note to self; after this merge Koenkk/zigbee2mqtt.io#2419 |
no, they don't thus the reason to set it to plug3. At least energy, immediate power, and voltage are shown properly with plug_3. Also on plug 1 I had these in logs on plug_3 only Maybe later I get Tuya gateway for debugging and getting proper data points. for now plug_3 works better for sure. |
|
Thanks! |
|
According to @smart-ctrl polling is not needed for this device (so TS011F_plug_1 should be fine). I think it is not working for your plug because of See this on how to enable the herdsman debug logging. Note that this is only logged to STDOUT and not to log files. |
|
This pull breaks the fix from Koenkk/zigbee2mqtt#20028 that was merged into v16.10.0. My _TZ3000_okaz9tjs plugs are now detected as BSD33_20A (aka TS011F_plug_3, polling) instead of TS011F_plug_1 (no polling). The symptoms in #6731 (comment) are consistent with the current non-dev branch, which does not have the proper check yet. Mine were working fine without polling in v16.10.0, v16.11.0 and v16.12.0. I am pretty sure the above versions should work for you as well @bullmastiffo, or if you're not on the dev branch this external converter should make the plugs work correctly for you. Otherwise it must mean these are different plugs with the same vendor and appversion, which I guess is a problem in itself. |
|
I'll try to grab logs and check out the external converter shortly. Then we will see how to proceed. Otherwise feel free to rollback for now. |
|
@DataGhost , thank you for pointing out! I've tested with your external converter, it works as expected. only same problem with magic packet, I will try to get the logs for that later. @Koenkk, So what is the best way forward? Should I just prepare the rollback PR? Shall I move the white label for BSD33_20A to plug_1 or just let it be detected as is? |
|
@Koenkk , so logs from initialization. |
|
@bullmastiffo I've reverted the PR for now, can you provide some more logging what comes after this? |
|
|
@DataGhost can you provide the debug log when configuring your plug? I think: |
|
@Koenkk hope this helps. It's from latest-dev (1.34.0-dev 27ccd1a with 16.15.0) not running any external converters. |
|
In your case the tuya configureMagicPacket also fails, so that's probably not the issue. @bullmastiffo did you already check with the latest dev which includes the fix from @DataGhost |
I've checked with latest dev, it's same with external converter, everything seems to work (current, voltage, power reporting via plug_1). Magic packet still fails. |
|
@bullmastiffo great, you can ignore the failed magic packet thing |
|
@bullmastiffo @DataGhost some more users are experiencing issues with energy measurements (power/voltage and current work). Do energy measurements work when detected as TS011F_plug_1? |
Koenkk
added a commit
that referenced
this pull request
Dec 30, 2023
|
@DataGhost reverted it! |
|
@Koenkk cool, will re-test as soon as the new docker image is up but it should probably just work. |
|
@Koenkk Confirmed this fixes my plugs again. These sure must be fun to support, huh :) I'd help out a bit with the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another version of tuya plug with energy polling. (On default plug
TS011F_plug_1energy is not available. plug_3 seems to work ok)device row in database:
{ "id": 16, "type": "Router", "ieeeAddr": "0xa4c138dbcd3d3ddd", "nwkAddr": 53360, "manufId": 4107, "manufName": "_TZ3000_okaz9tjs", "powerSource": "Mains (single phase)", "modelId": "TS011F", "epList": [ 1, 242 ], "endpoints": { "1": { "profId": 260, "epId": 1, "devId": 81, "inClusterList": [ 0, 3, 4, 5, 6, 10, 57344, 1794, 2820, 4096, 6280 ], "outClusterList": [ 25 ], "clusters": { "genBasic": { "attributes": { "modelId": "TS011F", "manufacturerName": "_TZ3000_okaz9tjs", "powerSource": 1, "zclVersion": 3, "appVersion": 112, "stackVersion": 2, "hwVersion": 0, "swBuildId": "0122052017" } }, "genOnOff": { "attributes": { "32768": 0, "onOff": 0, "tuyaBacklightMode": 0, "moesStartUpOnOff": 1, "onTime": 0, "offWaitTime": 0 } }, "haElectricalMeasurement": { "attributes": { "rmsVoltage": 234, "rmsCurrent": 0, "activePower": 0 } }, "seMetering": { "attributes": { "currentSummDelivered": [ 0, 149 ] } } }, "binds": [ { "cluster": 6, "type": "endpoint", "deviceIeeeAddress": "0xbc026efffe228982", "endpointID": 1 }, { "cluster": 2820, "type": "endpoint", "deviceIeeeAddress": "0xbc026efffe228982", "endpointID": 1 }, { "cluster": 1794, "type": "endpoint", "deviceIeeeAddress": "0xbc026efffe228982", "endpointID": 1 } ], "configuredReportings": [ { "cluster": 2820, "attrId": 1285, "minRepIntval": 5, "maxRepIntval": 3600, "repChange": 5, "manufacturerCode": null }, { "cluster": 2820, "attrId": 1288, "minRepIntval": 5, "maxRepIntval": 3600, "repChange": 50, "manufacturerCode": null } ], "meta": {} }, "242": { "profId": 41440, "epId": 242, "devId": 97, "inClusterList": [], "outClusterList": [ 33 ], "clusters": {}, "binds": [], "configuredReportings": [], "meta": {} } }, "appVersion": 112, "stackVersion": 2, "hwVersion": 0, "swBuildId": "0122052017", "zclVersion": 3, "interviewCompleted": true, "meta": {}, "lastSeen": 1702820389746, "defaultSendRequestWhen": "immediate" }