Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct lixee.ts logging #6672

Merged
merged 2 commits into from
Dec 10, 2023
Merged

Correct lixee.ts logging #6672

merged 2 commits into from
Dec 10, 2023

Conversation

qp68
Copy link
Contributor

@qp68 qp68 commented Dec 9, 2023

With Logger = console, debug log "zlinky config: ..." are spamming the console

With Logger = console, debug log "zlinky config:" are spamming the console
@Koenkk
Copy link
Owner

Koenkk commented Dec 9, 2023

Can you fix the failing checks?

@qp68
Copy link
Contributor Author

qp68 commented Dec 9, 2023

Done, hope it's the right way

@Koenkk Koenkk merged commit 5e2b0b2 into Koenkk:master Dec 10, 2023
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Dec 10, 2023

Thanks!

@qp68 qp68 deleted the patch-3 branch December 10, 2023 19:55
@qp68
Copy link
Contributor Author

qp68 commented Dec 10, 2023

@Koenkk There is an issue when starting Z2M due to my addition.

Zigbee2MQTT:error 2023-12-10 21:52:01: Failed to call 'Bridge' 'start' (TypeError: Cannot read properties of undefined (reading 'debug') at getCurrentConfig (/app/node_modules/zigbee-herdsman-converters/src/devices/lixee.ts:724:12) at Object.exposes (/app/node_modules/zigbee-herdsman-converters/src/devices/lixee.ts:800:27) at Device.exposes (/app/lib/model/device.ts:34:36) at Bridge.getDefinitionPayload (/app/lib/extension/bridge.ts:703:29) at /app/lib/extension/bridge.ts:657:34 at Array.map (<anonymous>) at Bridge.publishDevices (/app/lib/extension/bridge.ts:616:47) at Bridge.start (/app/lib/extension/bridge.ts:114:20) at processTicksAndRejections (node:internal/process/task_queues:96:5) at Controller.callExtensions (/app/lib/controller.ts:319:17))

I don’t know how to fix it so maybe it’s simpler to revert the commit.

Sorry

Koenkk added a commit that referenced this pull request Dec 11, 2023
Koenkk added a commit that referenced this pull request Dec 11, 2023
@Koenkk
Copy link
Owner

Koenkk commented Dec 11, 2023

Reverted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants