Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random tidying #6666

Merged
merged 3 commits into from
Dec 9, 2023
Merged

Random tidying #6666

merged 3 commits into from
Dec 9, 2023

Conversation

ghoz
Copy link
Contributor

@ghoz ghoz commented Dec 9, 2023

While browsing the source, some random oddities :

  • 2 devices use Tuya as vendor name rather than TuYa
  • Xiaomi MCCGQ13LM contact sensor using battery_cover rather than the much more common tamper
  • a double calibration of pm25 of STARKVIND Air purifier

ghoz added 3 commits December 9, 2023 11:12
2 odd devices with a Tuya vendor rather than TuYa
Xiaomi MCCGQ13LM had an odd "battery_cover" expose that alerts on open battery cover
All other devices call that "tamper". Go with the majority.
I don't own the device so cannot test
While looking at examples of calibration use , stumbled upon this double calibration for pm25
@ghoz
Copy link
Contributor Author

ghoz commented Dec 9, 2023

Let me know if you prefer that I split the PR...

@Koenkk Koenkk merged commit 5ba0dcd into Koenkk:master Dec 9, 2023
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Dec 9, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants