Add _TZE200_bcusnqt8 whiteLabel mapping #6228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Link to issue |
Koenkk
reviewed
Oct 4, 2023
src/devices/tuya.ts
Outdated
| @@ -5337,7 +5337,7 @@ const definitions: Definition[] = [ | |||
| ], | |||
| }, | |||
| { | |||
| fingerprint: [{modelID: 'TS0601', manufacturerName: '_TZE200_bcusnqt8'}], | |||
| fingerprint: tuya.fingerprint('TS0601', ['_TZE200_bcusnqt8']), | |||
There was a problem hiding this comment.
Since this device has only 1 model/fingerprint, I propose to update the vendor and model instead (and remove the whitelabel)
There was a problem hiding this comment.
Make sens. I don't know if this device is sold by another brand. Should I push a new PR with the change or you update directly on the main ? Thanks
There was a problem hiding this comment.
Done, sorry I didn't know I can update the PR. Thanks
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Yagusmart Tuya Zigbee smart energy sensor mapping