Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in parameter passed to broker in get_broker #158

Closed
kefin opened this issue Apr 6, 2016 · 1 comment · Fixed by #159
Closed

Typo in parameter passed to broker in get_broker #158

kefin opened this issue Apr 6, 2016 · 1 comment · Fixed by #159

Comments

@kefin
Copy link

kefin commented Apr 6, 2016

In the get_broker function in brokers.__init__.py, when returning a broker for a custom broker class (Conf.BROKER_CLASS), the parameter passed to broker is currently:

if Conf.BROKER_CLASS:
    module, func = Conf.BROKER_CLASS.rsplit('.', 1)
    m = importlib.import_module(module)
    broker = getattr(m, func)
    return broker(list_key=list)

The last line above (line 166 in brokers.__init__.py) should use list_key=list_key instead of list_key=list as parameter to the broker function call:

if Conf.BROKER_CLASS:
    module, func = Conf.BROKER_CLASS.rsplit('.', 1)
    m = importlib.import_module(module)
    broker = getattr(m, func)
    return broker(list_key=list_key)

The typo as it is now causes custom broker classes to fail when trying to connect because the list_key (with the value as a list class) causes a bad connection URL.

@Koed00
Copy link
Owner

Koed00 commented Apr 6, 2016

Good spot. Fixed it and I'll release it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants