-
-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow dispatch and allow workflow names. #969
Conversation
I'm looking for this functionality as well. Any chance to get this merged? |
I've tested using this PR, but there's an issue when dispatching without the optional
I think inputs should be omitted if there's no input to be specified… this works: public function dispatches(string $username, string $repository, string $workflow, string $ref, array $inputs = null)
{
$parameters = array_filter(['ref' => $ref, 'inputs' => $inputs]);
return $this->post('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/actions/workflows/'.rawurlencode($workflow).'/dispatches', $parameters);
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! 1 general remark/question, can you remove the @link
url changes and move them to a seperate PR as they are not related to this specific feature. This will allow the git history to give a better insight in why a certain change was done. Thanks!
Apart from 2 comments on the dispatch methods, this pr looks good! 👌
should be non-BC breaking now (even though Roave still doesn't like it), will wait for the URL update until this is merged |
Thanks @fodinabor! And congrats on your first contribution! 🎉 |
Adds the workflow dispatch proposed in #939.
This is different from the repository dispatch, as here it is clear what arguments to use, so that this is much more convenient to use.
Also update docs link.