Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the use of the RelevancyIndex with a Classifier instance #389

Open
Purg opened this issue Mar 19, 2019 · 0 comments
Open

Replace the use of the RelevancyIndex with a Classifier instance #389

Purg opened this issue Mar 19, 2019 · 0 comments

Comments

@Purg
Copy link
Member

Purg commented Mar 19, 2019

It seems like the RelevancyIndex interface and intent is just a specific use of a SupervisedClassifier instance upon a set of DescriptorElements. The IqrSession structure is the only thing currently (within SMQTK at least) that calls the RelevancyIndex.rank method (aside from tests), thus the only thing that requires the specific positive/negative classifier training and application to a DescriptorElement set. A more generalized structure here would be for the IqrSession to take in a SupervisedClassifier implementation config (instead of a RelevancyIndex) and IqrSession.refine to define the training and application logic that is specific to the IQR process instead of fragmenting it out into a separate class (the RelevancyIndex).

This would also work to address opening up the use of other supervised classifiers for use in IQR refinement instead of currently needing to implement an analogous RelevancyIndex.

@Purg Purg changed the title Replace the use of the RelevancyIndex with just a Classifier instance Replace the use of the RelevancyIndex with a Classifier instance Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant