Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-completion is overly aggressive when an expression ends with "10" #4119

Closed
yeroca opened this issue Oct 8, 2024 · 1 comment
Closed

Comments

@yeroca
Copy link

yeroca commented Oct 8, 2024

[Add a title above and insert a description of the issue here]

When writing some code, if an expression ends with 10 somehow, then I hit enter, the 10 turns into "log10(3.14)" because that was what was suggested by auto-completion.

Screenshot

Core Dump

coredump-71f4c7ee-7925-40c6-bc12-7e294bf17753.json

Reference ID: 71f4c7ee-7925-40c6-bc12-7e294bf17753

KCL Code
numSides = 12

cornerAngle = 360 / numSides
diam = 19.9

rad = diam / 2

sideLen = rad * sin(toRadians(cornerAngle / 2)) * 2
centerYOffset = rad * cos(toRadians(cornerAngle / 2))

slowMode = log10(3.14)
fn dodecagon = () => {
  sketch001 = startSketchAt([-sideLen / 2, -centerYOffset])
  return reduce([0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10], sketch001, (i, sg) => {
  return angledLine({
  angle: i * cornerAngle,
  length: sideLen
}, sg)
})
}

sketch010 = dodecagon()
  |> close(%)
  |> extrude(7, %)

sketch002 = startSketchOn(sketch010, 'END')
  |> circle({ center: [0, 0], radius: 16 }, %)
  |> extrude(4, %)

@guptaarnav
Copy link
Collaborator

guptaarnav commented Nov 9, 2024

Closed by #4341 (in the following commit: showing no completions when last typed word is a number)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants