Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull out updateAstAndFocus in order to make unit tests for applyFilletToSelection #3831

Closed
Tracked by #2606
max-mrgrsk opened this issue Sep 7, 2024 · 0 comments · Fixed by #3832
Closed
Tracked by #2606
Assignees

Comments

@max-mrgrsk
Copy link
Collaborator

max-mrgrsk commented Sep 7, 2024

This issue is part of the larger Fillet UI (#2606) project.

Currently, the updateAstAndFocus function is invoked directly within the main function applyFilletToSelection , which causes challenges when running unit tests. Specifically, the kclManager.updateAst command is not compatible with our current unit test setup.

To resolve this, we need to refactor the code and pull the updateAstAndFocus function out of the main flow. This will allow us to properly test the core functionality. Which is needed for upcoming multiple selection tests.

@max-mrgrsk max-mrgrsk self-assigned this Sep 7, 2024
@max-mrgrsk max-mrgrsk linked a pull request Sep 7, 2024 that will close this issue
@max-mrgrsk max-mrgrsk mentioned this issue Sep 12, 2024
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant