Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AST Fillet mod for Selecting Multiple Edges #3680

Closed
Tracked by #2606
max-mrgrsk opened this issue Aug 27, 2024 · 1 comment · Fixed by #3724
Closed
Tracked by #2606

AST Fillet mod for Selecting Multiple Edges #3680

max-mrgrsk opened this issue Aug 27, 2024 · 1 comment · Fixed by #3724
Assignees
Labels
ast Issues / features relevant to ast and parser. dev Issues related to development of the app.

Comments

@max-mrgrsk
Copy link
Collaborator

max-mrgrsk commented Aug 27, 2024

I need edges, lots of edges

This issue is part of the larger Fillet UI (#2606) project.

Problem

Currently, the Fillet UI only allows applying fillets to a single edge at a time.

Task

The goal of this issue is to extend that functionality to support the selection of multiple edges.
So you can apply fillets to several edges simultaneously.

Limitations

Currently the engine won't fillet any adjacent edges but otherwise is fine

@max-mrgrsk max-mrgrsk mentioned this issue Aug 27, 2024
45 tasks
@max-mrgrsk max-mrgrsk changed the title Select multiple edges Support for Selecting Multiple Edges in Fillet UI Aug 27, 2024
@max-mrgrsk max-mrgrsk self-assigned this Aug 27, 2024
@max-mrgrsk max-mrgrsk added ast Issues / features relevant to ast and parser. dev Issues related to development of the app. labels Aug 29, 2024
@max-mrgrsk max-mrgrsk linked a pull request Aug 29, 2024 that will close this issue
@max-mrgrsk
Copy link
Collaborator Author

I will dig into both options:

  1. Iterating Over addFillet (easy)
  2. Modifying addFillet to Handle Multiple Selections (performant)

@max-mrgrsk max-mrgrsk changed the title Support for Selecting Multiple Edges in Fillet UI AST Fillet mode for Selecting Multiple Edges Sep 8, 2024
@max-mrgrsk max-mrgrsk changed the title AST Fillet mode for Selecting Multiple Edges AST Fillet mod for Selecting Multiple Edges Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ast Issues / features relevant to ast and parser. dev Issues related to development of the app.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant