Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Create file" and "Create folder" buttons in file pane should not create items, only queue them to be made if name form is submitted #3605

Closed
franknoirot opened this issue Aug 21, 2024 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@franknoirot
Copy link
Collaborator

Currently, clicking these buttons in the file pane UI immediately creates a new file or folder with the name "Untitled" and an index suffix, then sets that new item to be in "renaming mode" so you can immediately set its name.

Screenshot 2024-08-21 at 8 59 15 PM

Instead, we should follow the example of VS Code. Clicking those buttons opens a UI form to set its name, and if you submit this form the file or folder is then created. If you cancel with Esc or by blurring focus on the input no file system access occurs.

This should include an Electron E2E test or Vitest component test of the behavior.

@franknoirot franknoirot added the duplicate This issue or pull request already exists label Aug 21, 2024
@franknoirot
Copy link
Collaborator Author

Duplicate of #3248

@franknoirot franknoirot marked this as a duplicate of #3248 Aug 21, 2024
@franknoirot franknoirot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

1 participant