Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: User menu should show Command, not Control, on mac #3567

Closed
jtran opened this issue Aug 20, 2024 · 1 comment · Fixed by #3573
Closed

[BUG]: User menu should show Command, not Control, on mac #3567

jtran opened this issue Aug 20, 2024 · 1 comment · Fixed by #3573
Labels
bug Something isn't working desktop-app Issues from the desktop app.

Comments

@jtran
Copy link
Collaborator

jtran commented Aug 20, 2024 •
edited
Loading

Describe the bug

On mac, it should show the command symbol for the User Settings shortcut.

Steps to Reproduce

  1. yarn tron:start
  2. Click user menu

Expected Behavior

This is what the current production app looks like.

Screenshot 2024-08-20 at 12 17 30 PM

Screenshots and Recordings

This is what I see now.

Screenshot 2024-08-20 at 12 14 20 PM

Desktop OS

macOS 14.6.1

Browser

No response

Version

main, post electron aac758b396

Additional Context

No response
@jtran jtran added the bug Something isn't working label Aug 20, 2024
@jtran jtran changed the title [BUG]: User menu should show Comamnd, not Control, on mac [BUG]: User menu should show Command, not Control, on mac Aug 20, 2024
@jessfraz jessfraz added the desktop-app Issues from the desktop app. label Aug 20, 2024
@jessfraz
Copy link
Contributor

this is so weird since it was fine on tauri

@jtran jtran self-assigned this Aug 20, 2024
@jtran jtran mentioned this issue Aug 20, 2024
Merged
@github-actions github-actions bot mentioned this issue Aug 26, 2024
Merged
@jtran jtran removed their assignment Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working desktop-app Issues from the desktop app.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix to convert electron platform name darwin to macos KittyCAD/modeling-app
2 participants
@jtran @jessfraz