Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text-to-cad things get into bad state, if its trying to generate a file in a dir and errors #3447

Closed
jessfraz opened this issue Aug 15, 2024 · 4 comments
Closed

text-to-cad things get into bad state, if its trying to generate a file in a dir and errors #3447

jessfraz opened this issue Aug 15, 2024 · 4 comments
Assignees
@franknoirot
Labels
browser Issues from the browser app. bug Something isn't working desktop-app Issues from the desktop app.

Comments

@jessfraz
Copy link
Contributor

jessfraz commented Aug 15, 2024 •
edited
Loading

Image from Slack

see convo here: https://kittycadworkspace.slack.com/archives/C06L2RHP9SL/p1723691545904259
@jessfraz jessfraz added bug Something isn't working desktop-app Issues from the desktop app. browser Issues from the browser app. labels Aug 15, 2024
@jessfraz jessfraz mentioned this issue Aug 15, 2024
Closed
@jessfraz
Copy link
Contributor Author

jessfraz commented Aug 15, 2024 •
edited
Loading

pr with browser failing tests for these things: #3448

@jessfraz
Copy link
Contributor Author

actually if you read thru the convo the toasts never disappear which is good its just if the app crashes because of trying to generate a file in a dir and failing we get in a bad state so reversed my tests to make sure all the toasts would stack up til you interact w them and now we just need the fs bug fixed

@jessfraz jessfraz changed the title text-to-cad if you ignore toast things get into bad state text-to-cad things get into bad state, if its trying to generate a file in a dir and errors Aug 15, 2024
@jessfraz
Copy link
Contributor Author

on further review i know the exact issue and its the fucking tauri file perms issue

we have no access to that dir

so we cant fix this til we get electron in

its the same thing as always

@jessfraz
Copy link
Contributor Author

we will add a test for this when electron is in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@franknoirot franknoirot

Labels
browser Issues from the browser app. bug Something isn't working desktop-app Issues from the desktop app.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessfraz @franknoirot