Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconnection issue (theme change) #3265

Closed
Irev-Dev opened this issue Aug 4, 2024 · 4 comments
Closed

Reconnection issue (theme change) #3265

Irev-Dev opened this issue Aug 4, 2024 · 4 comments
Labels
bug Something isn't working high-priority

Comments

@Irev-Dev
Copy link
Collaborator

Irev-Dev commented Aug 4, 2024

It seems killing the browser's connection doesn't re-establish the stream when theme changes

Screenshare.-.2024-08-05.8_29_57.AM.mp4

Failing test for this issue here #3264

Related to #3250

CC @lf94
This was referenced Aug 4, 2024
Merged
Merged
@jessfraz jessfraz added bug Something isn't working high-priority labels Aug 13, 2024
@Irev-Dev
Copy link
Collaborator Author

@lf94 I have a feeling this might have been resolved. did it?

@jessfraz
Copy link
Contributor

should we add the test on main and see?

@lf94
Copy link
Contributor

lf94 commented Aug 20, 2024 •
edited
Loading

I thought we (me) fixed it for AME yeah. We should just add a test.

@github-actions github-actions bot mentioned this issue Aug 26, 2024
Merged
@Irev-Dev
Copy link
Collaborator Author

Yeah #3264 is the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working high-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lf94 @jessfraz @Irev-Dev