-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electron test: (regression) deleting all files, creating multiple untitled files, creating a file with the same name, creating a file and renaming it to an already existing file #3088
Comments
we will want a tauri test/electron test/playwright test whatever for this |
main.kcl
is present leads to app crashmain.kcl
is present leads to app crash
be sure to test this as well: open project -> rename main.kcl to hello.kcl |
create a new file with the same same; delete all files; create a new file leave it as Untitled, create another, etc |
This causes the stream to not reload the model, leaving the old model there (but deletes all the code and causes no crashes). main.kcl is recreated when reloading the app. |
This causes the old file to be overwritten with no warning. (This was not the case when I ported; it would stop you, throwing an EEXISTS error.) |
Both are fixed now in the upcoming PR. |
main.kcl
is present leads to app crash
Resolved by #3679 |
It must be something about our routing logic sending the user to a fallback part that is causing the issue, probably assuming a
main.kcl
. We should just send the user to the project root because we have Rust-side fallback logic that will go to the first available file or create amain.kcl
if no KCL files at all are found.Demo
Screenshare.-.2024-07-19.5_33_28.PM-compressed.mp4
The text was updated successfully, but these errors were encountered: