Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More of the logic in AST fillet action should be tested #3036

Closed
Tracked by #2606
Irev-Dev opened this issue Jul 16, 2024 · 1 comment · Fixed by #3530
Closed
Tracked by #2606

More of the logic in AST fillet action should be tested #3036

Irev-Dev opened this issue Jul 16, 2024 · 1 comment · Fixed by #3530
Assignees
Labels
dev Issues related to development of the app. tests Pull requests that update or improve our test suite

Comments

@Irev-Dev
Copy link
Collaborator

Irev-Dev commented Jul 16, 2024

The function addFillet has some unit tests, but there's plenty of logic that goes into the AST mod that is still in the AST fillet action that isn't captured by these tests.

We could put more in a testable function, something like

function AstFillet(ast: Program, selections: Selections, cmdValue: KclCommandValue: programMemory: ProgramMemory): Program {
  // ...
}

☝️ I might be missing inputs, main thing I'm worried about is the pathToExtrudeNode being neglected

@Irev-Dev Irev-Dev mentioned this issue Jul 16, 2024
45 tasks
@jessfraz jessfraz added dev Issues related to development of the app. tests Pull requests that update or improve our test suite labels Jul 25, 2024
@max-mrgrsk max-mrgrsk self-assigned this Aug 4, 2024
@max-mrgrsk
Copy link
Collaborator

Added tests for getPathToExtrudeForSegmentSelection:

Implemented tests to check if the function correctly identifies extrude paths from selected segments in different sketches. The tests cover various scenarios, including multiple extrusions and cases where no extrusion exists, ensuring the logic works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Issues related to development of the app. tests Pull requests that update or improve our test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants