Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Github oauth tutorial is not OpenID Connect compliant. #508

Closed
Natim opened this issue Mar 15, 2016 · 2 comments · Fixed by #3502
Closed

The Github oauth tutorial is not OpenID Connect compliant. #508

Natim opened this issue Mar 15, 2016 · 2 comments · Fixed by #3502
Labels
bug documentation help wanted question scope:authentication stale For marking issues as stale. Labeled issues will be closed soon if label is not removed.

Comments

@Natim
Copy link
Member

Natim commented Mar 15, 2016

As @jmandel described in his comment on the tutorial

In order to use GitHub sign-in safely, you need to ensure the token you pass to Kinto API endpoints is intended for Kinto. In an ideal world, GitHub would help with this problem by creating a signed token designed for the application to consume. This is what the ID token accomplishes in OpenID connect. Since GitHub does not do this for you, you would need to do it yourself.

Using Github Bearer Token to authenticate directly to Kinto without any specific scoping of the Bearer Token means that any application having a Github Bearer Token for the user can manage, read, add and delete her Kinto data. This is not acceptable for production use.

This remembers me a discussion we had a month ago in London with @michielbdejong where he explained me that RemoteStorage embedded an OpenID Connect compatible server in charge of generating RemoteStorage scoped specific Bearer Token.

How should we handle this for Kinto, what is the plan forward to have a better OAuth2 integration.

Thoughts?

@Natim Natim added the question label Mar 15, 2016
@jmandel
Copy link

jmandel commented Mar 15, 2016

Fundamentally the challenge is that OAuth is designed as an authorization protocol. You can build an authentication protocol on top, but you have to be careful to get the details right (like OIDC). For details see http://oauth.net/articles/authentication/ by @jricher.

@leplatrem
Copy link
Contributor

@alexcottner alexcottner added the stale For marking issues as stale. Labeled issues will be closed soon if label is not removed. label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug documentation help wanted question scope:authentication stale For marking issues as stale. Labeled issues will be closed soon if label is not removed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants