[BUG] New Response in downloadAction puts additional HTML into download files

[Bunnyfield]

With 21e4c62 the old way of providing a download file before doing an exit() has been replaced with a response created by the responseFactory.

Since Extbase does not focus on that response only, there is additional HTML content written into the file stream, creating broken download files with binary code surrounded by HTML.

According to the core docs, there should be an exception to avoid that behaviour:
https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ExtensionArchitecture/Extbase/Reference/Controller/ActionController.html#stop-further-processing-in-a-controller-s-action

Changing the return to

$response = $this->responseFactory->createResponse()
  ->withHeader('Content-Type', $cType)
  ->withHeader('Pragma', 'public')
  ->withHeader('Expires', '-1')
  ->withHeader('Cache-Control', 'public')
  ->withHeader('Content-Disposition', 'attachment; filename="' . $fileNameValid . '"')
  ->withHeader('Content-Length', $fileLen)
  ->withBody($this->streamFactory->createStreamFromFile($privateUri));

throw new PropagateResponseException($response, 200);

creates download files properly.

[Kephson]

Thank you very much Jo, I will check and implement it.

[SicorDev]

I can confirm the problem, as well as the suggested solution. It just seems that the full page is unnecessarily rendered before it switches to the downloaded PDF. Observed in Firefox with the Exception code as above. Don't forget to add the "use" statement for the exception.

[Kephson]

Closed with the newest release 4.0.1: https://github.com/Kephson/reint_downloadmanager/releases/tag/4.0.1 and the commit 75403b2