Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extensions.json #160

Closed
wants to merge 1 commit into from
Closed

Conversation

Tapasyamahor1
Copy link

Motivation

Which issue does this fix? Fixes #issue number

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@Tapasyamahor1 Tapasyamahor1 requested a review from a team as a code owner June 15, 2023 08:40
@seangwright
Copy link
Member

seangwright commented Jun 15, 2023

Hey @Tapasyamahor1, thanks for the contribution.

Unfortunately there's a couple of issues here.

  1. Your project doesn't target Kentico Xperience 13 - it targets Kentico 12 MVC, so the information you've added in the JSON file here is incorrect.
  2. You've just copied @liamgold's project without any attribution.
  3. There is no new NuGet package for your project - it points to the NuGet package that @liamgold created.
  4. You didn't fill out any information in the PR template. Please fill this out with some context/details in the future.

I would recommend you avoid copying other people's code without giving them attribution, even if the license is MIT.

If, in the future, you have something new to contribute you can make another PR. Until then I'm closing this one.

@seangwright seangwright mentioned this pull request Jun 21, 2023
5 tasks
@Tapasyamahor1 Tapasyamahor1 deleted the patch-1 branch June 22, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants