Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing top stroke in 饗 #171

Closed
twwn opened this issue Mar 20, 2018 · 7 comments · Fixed by #303
Closed

Missing top stroke in 饗 #171

twwn opened this issue Mar 20, 2018 · 7 comments · Fixed by #303
Labels
Stroke shapes The shapes which strokes take Variant forms Different forms of characters

Comments

@twwn
Copy link

twwn commented Mar 20, 2018

The Jinmeiyō 09957/饗 is missing the top stroke of its upper middle component, perhaps a mistake due to 郷 being shinjitai and 鄕 kyūjitai.

It's already there in the kanji_mismatch variants, but omitted from the three "normal" files.

See eg.:

@ospalh
Copy link
Member

ospalh commented Mar 21, 2018

Oh, looks like you are right.
I missed the version in the kanji_mismatch directory, and missed that dot when i changed this a while ago.
And it looks like it should not be there in the two pre-2004 variant versions.

In the second row in the picture, on the left is the modern “IPAPMincho” font, with the extra dot, second is the older “MotoyaLMaru”, which is like the two “hyougai” variants. Those stay, the “plain” variant should get the extra dot.
anki-

@wtn
Copy link

wtn commented Jun 29, 2018

Yes, MJ028567 is the most correct form. [EDIT: link updated 2021-04-18]

mj028567

@benkasminbullock
Copy link
Member

IDS gives this as not having a dot in Japanese usage:

U+9957 饗 ⿱鄉食[GT] ⿱郷食[J] ⿱鄕食[K]

Here the [J] means Japanese.

@wtn
Copy link

wtn commented Apr 18, 2021

@benkasminbullock The IDS file is not authoritative. It's better to look at the code chart.
u9957

@benkasminbullock
Copy link
Member

You say that it's better to look at the code chart, and you post an image of unknown provenance, and the above link in your previous post from 2018 is dead. The IDS chart is what is used by the committee which makes the Unicode Han tables (as far as I know), so it is actually authoritative in the sense that it is being used by the people who are deciding these things. Anyway, your response is not very useful without clear referencing.

@wtn
Copy link

wtn commented Apr 19, 2021

The glyphs in the CJK ideograph code charts are the shapes endorsed by the national bodies. The IDS data file is not authoritative. It's merely one input the IRG uses in their duplicates check process.

The image from June 2018 is from the Moji Joho Kiban project. (The link broke because the project moved, but I've updated the link so it works again now.) The image from Apr 2021 is from the Unicode 13 code chart. The shapes for both are basically identical. But this character is on the 印刷標準字体 list, so both 鄕 & 郷 are acceptable. It's really up to whatever you want to do.

For a font example using a handwritten style, here's an image from the 漢検 dictionary:
kanken

@benkasminbullock
Copy link
Member

I suggest renaming kanji_mismatch/09957-Jinmei.svg to kanji/09957.svg with the following changes:

  • Add the missing stroke numbers for stroke 21 and 22
  • Add kvg:type for paths with ids s21 and s22
  • Substitute the path of stroke 15 of kanji/09957.svg for stroke 16

The final suggestion is based on the form of the character in the PDF link.

I'm not sure what to rename the existing kanji/09957.svg, since there is already a "Hyougai" version of this which uses the food radical with a ム bottom part rather than the two horizontal lines used in kanji/09957.svg. Perhaps we can literally just call it kanji/09957-NoUpperDot.svg or something like that.

If this is acceptable I'll do the editing work by hand on the above character and rename it. If nobody speaks up I'll just go ahead, so please let me know if you have objections.

@benkasminbullock benkasminbullock added Stroke shapes The shapes which strokes take Variant forms Different forms of characters labels Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stroke shapes The shapes which strokes take Variant forms Different forms of characters
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants