Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element completions and suggestions don't work as expected #24

Closed
WebVeteran opened this issue Oct 11, 2018 · 2 comments
Closed

Element completions and suggestions don't work as expected #24

WebVeteran opened this issue Oct 11, 2018 · 2 comments

Comments

@WebVeteran
Copy link

Adding CFML tags don't:

  • suggest tags while typing
  • wrap selected suggestion attributes in quotes
  • auto close only when "</" is entered (it happens as soon as you enter ">"
  • auto indent the next line

Adding a HTML tags do:

  • suggest tags while typing
  • wrap selected suggestion attributes in quotes
  • auto close only when "</" is entered
  • auto indent the next line

See attached zipped mp4.
suggestions.mp4.zip

@KamasamaK
Copy link
Owner

Thanks for the video. Here are my responses:

  1. Adding a CFML tag should
    a. Suggest tags while typing: This has been a feature since the initial release. I'm not sure why it isn't working for you. The only thing I can think of is your cfml.suggest.globalTags.enable is not set to true.
    b. Append quotes when completing suggested attributes: There is now a setting cfml.suggest.globalTags.attributes.quoteType for this which defaults to double.
    c. Auto-close only when </ is entered: This is handled by the auto-close-tag extension. See my response in HTML Element completion and in/out-dent not working properly #23.
    d. Auto-indent the next line: The indentation should work this way in v0.5.0+.

@WebVeteran
Copy link
Author

I updated VSC and extensions, so giving it another shot here.

a) It works. Though cfml.suggest.globalTags.enable was always set to true.
b) It works.
c) It works.
d) It works.

Awesome work @KamasamaK !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants