Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-Demand Backups #98

Open
Kaiede opened this issue Dec 6, 2024 · 1 comment · Fixed by #101
Open

On-Demand Backups #98

Kaiede opened this issue Dec 6, 2024 · 1 comment · Fixed by #101
Labels
enhancement New feature or request

Comments

@Kaiede
Copy link
Owner

Kaiede commented Dec 6, 2024

#97 brought up the issue of On Demand backups.

Some requirements to bring this about:

  • Need a way to signal the service that a backup is requested.
  • Need the service to act on that signal.

The work for #93 would provide the means to do the signaling.

There would be some thinking required related to security here, as there are some denial-of-service attacks that would be possible if this was available over the HTTP endpoint. Perhaps triggering this should require a token that is only stored inside the container and not accessible via the usual volume mount points. So while someone could do something like docker exec -it minecraft_backup /start-backup.sh, where the script can read the token and provide it to the service, an attacker would already need access to the container filesystem in which case they could attack the backup folder directly anyways.

@Kaiede Kaiede added the enhancement New feature or request label Dec 6, 2024
@Kaiede Kaiede linked a pull request Dec 6, 2024 that will close this issue
@Kaiede Kaiede reopened this Dec 6, 2024
@Kaiede
Copy link
Owner Author

Kaiede commented Dec 6, 2024

This will be in the test tag shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant