Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some engines descriptions like Agena B and D restart penalties are overwritten by RP-1, but descriptions should be maintained in RO. #2308

Closed
Karhgath opened this issue Dec 3, 2023 · 2 comments

Comments

@Karhgath
Copy link
Contributor

Karhgath commented Dec 3, 2023

While investigation why Agena B and D description is different from RO configs

Config:
https://github.com/KSP-RO/RealismOverhaul/blob/32ab62ccbde3600b6c22c5bd78d1161ef1f5c08e/GameData/RealismOverhaul/Engine_Configs/Agena_XLR81_Config.cfg#L395
https://github.com/KSP-RO/RealismOverhaul/blob/32ab62ccbde3600b6c22c5bd78d1161ef1f5c08e/GameData/RealismOverhaul/Engine_Configs/Agena_XLR81_Config.cfg#L461

In game:
image

I figured out that TREE-Engines.cfg overwrites many engines descriptions.
https://github.com/KSP-RO/RP-1/blame/ad4f136d5982cb9fc35216fa4ae24007d8c69292/GameData/RP-1/Tree/TREE-Engines.cfg#L5424

Would the proper fix be to remove all description in this file, not sure if any are necessary (e.g. not defined anywhere else)?

@lpgagnon
Copy link
Contributor

lpgagnon commented Dec 3, 2023

easy fix would be to get rid of

if 'description' in part and len(part['description']) > 0:
optional_attributes += """
%description = """ + part['description']

(if there are engine configs lacking descriptions, that'd be a RO bug to fix separately)

@Capkirk123
Copy link
Member

resolved by fc28721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants