Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Reinstall #2154

Closed
Real-Gecko opened this issue Oct 19, 2017 · 18 comments
Closed

[Feature] Reinstall #2154

Real-Gecko opened this issue Oct 19, 2017 · 18 comments
Assignees
Labels
Cmdline Issues affecting the command line GUI Issues affecting the interactive GUI
Milestone

Comments

@Real-Gecko
Copy link

Would be nice to have "Reinstall" button, so that mod is removed and unpacked again, just in case user messes up with mod files.

@politas
Copy link
Member

politas commented Oct 20, 2017

Is removing and installing as a two step process that much of a headache? We can clutter up the UI with separate buttons for every possibility, I suppose...

@Real-Gecko
Copy link
Author

Sometimes it happens that other mods depend on mod in question, so uninstalling it will trigger uninstallation of dependants. I agree that button is not quite a good idea, maybe right click dropdown?

@politas politas added Cmdline Issues affecting the command line Enhancement New features or functionality labels Oct 20, 2017
@politas
Copy link
Member

politas commented Oct 20, 2017

Would you be happy with a Command Line implementation only?

@politas politas added the GUI Issues affecting the interactive GUI label Oct 20, 2017
@politas
Copy link
Member

politas commented Oct 20, 2017

Another possibility is to start using the Mod Versions panel to give us extra functionality - Install a specific version, reinstall current version, set AD version, download selected version...

@Real-Gecko
Copy link
Author

Shame to ask, but what is Mod Versions panel?

@linuxgurugamer
Copy link
Contributor

The panel on the right, where it shows you information on the mod, the tab is Versions

@Real-Gecko
Copy link
Author

Yep, I think that'll be pretty cool.

@Olympic1
Copy link
Member

I worked on a right click menu and could add this option to the menu. But we'll need a process for the reinstall. I thought of the following:

We uninstall the mod, so that we have clean install, and then install the mod again. When doing this it will remove its dependants, so could this be possible without removing its dependants?

@Olympic1 Olympic1 self-assigned this Nov 26, 2017
@Olympic1 Olympic1 added this to the 1.24.0 milestone Nov 26, 2017
@Real-Gecko
Copy link
Author

Well, maybe something like a dirty hack: remove mod folder, unpack mod from cache like it's done while installing the mod?

@politas
Copy link
Member

politas commented Dec 3, 2017

Should be able to do it like an upgrade, but to the same version instead of the new version.

@solarsootysmudge
Copy link

As much as like the comments and suggestions so far. I got to bring up the whole policy of not deleting folders on uninstall thing again. I believe that that effects the above conversation and should be considered further.

CKAN can't never be trusted to do a full reinstall with every mod without end users making a choice of how to handle config files created by the mod at run time. There are mods that install files after the CKAN process is completed. The policy rule has been if CKAN did not install it those extra files. It can't remove them.

Removing and installing as a two step process that is easy to do. However some mods make it more complicated. Once the mod is uninstalled in CKAN. The end user must manually check if the mod folder still exists. Depending on the mod the files left behind can be considered safe to leave in place or they must be manually removed. After this manual folder check. The mod can be reinstalled. How often does the extra mod created files problem come up. I think it is still rare and always has been. None the less it has been the root cause of a whole bunch of arguments over the years.

Still I think it is worth considering if config files created by the mod at run time can any impact on putting in a button that does an a reinstall action. How to handle an automated action where these extra files exist after mod removal?

@7ranceaddic7
Copy link

How to handle an automated action where these extra files exist after mod removal?

Ask the user, "Do you want to remove all files and folders associated with this mod?"

@linuxgurugamer
Copy link
Contributor

I support this, for the following reason:

Example: I uninstalled Tweakscale, but MM was still applying various Tweakscale patches. Turns out that the directory was still there, and MM saw it.

I think that the extra mod-created files can be a real issue, especially if someone is trying out a lot of mods trying to settle on a good mix.

When asking the question, you will have to consider the fact that more than one mod may be removed at the same time. So the question would either have to be global, for all mods being removed, or asked for each mod being removed.

@HebaruSan
Copy link
Member

The discussion of uninstalling with mod-generated files is probably best had at #653. That issue is much broader than a reinstall feature, and whatever solution is figured out in the general case would apply here the same way.

@solarsootysmudge
Copy link

solarsootysmudge commented Dec 6, 2017

The best place to look is my rather verbose research at #1610. Where I did do a deep dive into all the passed issues including #653. The short answer is. It is a bigger can of worms that first appears. It has never been completely solved but I do think it was made as easy to fix as possible for end users.

Longer answer: Since then we first talked about this there have had two merges that have made this even more rare. Links to those also included at the end of #1610 too.

Force reinstall on dependency change. Some mod authors would change them without a version bump in the mod. Leading to state where the local client files did not update even although metadata was changed in the main repo. Might be worth looking at this one for new ideas for reinstall use cases.

There was also the removal of an mod empty folder added in. As @linuxgurugamer says above this is the biggest problem. MM can install patches based on FOR or NEEDS logic. Leaving a just a folder is enough to get bad installs. The catch here is if the mod author has created an extra file at run time. The new feature will not delete the folder.

@7ranceaddic7 I agree that the answer could be as simple as. Ask the user, "Do you want to remove all files and folders associated with this mod?" Then following through on folder removal regardless of what it contains. Whilst the counter argument has always be "CKAN will never delete files it does not install"

So far the biggest progress made is when documentation was put up explaining how to do a proper clean reinstall. The ability to export a mod list and use that to rebuild everything is powerful. If most end users followed that advice. A lot of support issues would be solved. Again #1610 links to it.

@solarsootysmudge
Copy link

solarsootysmudge commented Dec 7, 2017

Also worth reading the comment at the end of #1720 where a suggested PR did not not think about the implications of #1610.

@HebaruSan
Copy link
Member

Wherever the best place is, the point was: it's not here. :) :(

@politas
Copy link
Member

politas commented Jan 5, 2018

This has been implemented in #2202

@politas politas closed this as completed Jan 5, 2018
@politas politas removed Enhancement New features or functionality ★★☆ labels Jan 5, 2018
@HebaruSan HebaruSan changed the title Feature request: reinstall [Feature] Reinstall Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cmdline Issues affecting the command line GUI Issues affecting the interactive GUI
Projects
None yet
Development

No branches or pull requests

7 participants