Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Kyc Dapp methods implement the ENS interface (gets feature to use of ethers js) #143

Closed
3 tasks
zemse opened this issue Sep 5, 2020 · 1 comment
Closed
3 tasks
Labels
enhancement New feature or request

Comments

@zemse
Copy link
Contributor

zemse commented Sep 5, 2020

  • Need to check with boss if time can be allotted for this.
  • Populate some more blogs/docs for references before implementing this.
  • Kyc dapp will need to deploy child resolver contracts, try if breaking changes can be prevented.

References:

@zemse zemse added the enhancement New feature or request label Sep 5, 2020
@zemse
Copy link
Contributor Author

zemse commented Oct 2, 2020

This is actually done somewhat.

I created a CustomProvider, that overrides the resolveName and lookupAddress methods in the provider of ethers.js so it works with the non-standard method in KycDapp contract. And it's working great like, I can use a kyc name anywhere ethers.js accepts an address.

@zemse zemse closed this as completed Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant