Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: copy jsonabc into project #293

Merged
merged 1 commit into from
Jul 24, 2020
Merged

feat: copy jsonabc into project #293

merged 1 commit into from
Jul 24, 2020

Conversation

tjwelde
Copy link
Contributor

@tjwelde tjwelde commented Jul 24, 2020

NO-TICKET

Since we always have problems with the jsonabc library in react-native, I copied it directly into the project.

The problems stemmed from the library using a browser field in their package.json, but not building the library, so it leads to nothing.
In the past we built the file in our react-native projects, which is already not a good solution. To save this hassle, I just copied it here.

How to test:

  • tests should run

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@tjwelde tjwelde requested a review from LeonFLK July 24, 2020 11:01
Copy link
Member

@Dudleyneedham Dudleyneedham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjwelde tjwelde merged commit a32f8af into develop Jul 24, 2020
@tjwelde tjwelde deleted the tw-include-jsonabc branch July 24, 2020 11:53
@wischli wischli added this to the v0.19.0 milestone Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants