feat: publishing to github packages from develop #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rflechtner
force-pushed
the
publish-github-package
branch
from
12e2176 to
beb2b62
Compare
This reverts commit a34ed45.
rflechtner
force-pushed
the
publish-github-package
branch
from
f80a01d to
a4aa5c5
Compare
rflechtner
force-pushed
the
publish-github-package
branch
from
a4aa5c5 to
8034705
Compare
rflechtner
force-pushed
the
publish-github-package
branch
from
8034705 to
8d8fcdd
Compare
tjwelde
reviewed
Jun 26, 2020
.npmrc
Outdated
| @@ -1 +0,0 @@ | |||
| tag-version-prefix="" | |||
There was a problem hiding this comment.
The tag version prefix was necessary for doing the public release to npm registry. Is it obsolete?
There was a problem hiding this comment.
I don't actually know - it looked like Dudley introduced this with his last PR and he said it was irrelevant, so I removed it. If we still need it, I can put it back in
This reverts commit eaeafb9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#599
Builds and publishes the sdk as a npm package to the GitHub Packages repo.
These releases are versioned with the current commit id and tagged
dev.Possible issues:
.npmrcin this repo that may interfere with the publishing processpackage.jsonmentions a target for publishing (publishConfig) that could potentially interfereHow to test:
By adding this branch to the triggers I have successfully triggered a release. You can find the published package in https://github.com/KILTprotocol/sdk-js/packages/286306.
Checklist: