Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service qualifier needed on chracteristic events #92

Open
davertay-j opened this issue Jan 22, 2025 · 0 comments
Open

Service qualifier needed on chracteristic events #92

davertay-j opened this issue Jan 22, 2025 · 0 comments

Comments

@davertay-j
Copy link
Collaborator

In a few of the characteristic events we are relying on only the peripheral and characteristic ids to match the request promise. This is probably fine in almost all cases, but to be 100% correct the event key lookup should include the service id.

There may be more than one place to fix so would require auditing the entire app, but the starting place would be ChracteristicEvent.swift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant