Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: apstra_telemetry_service_registry_entry rename service_name to name #724

Closed
chrismarget-j opened this issue Jul 15, 2024 · 2 comments
Assignees

Comments

@chrismarget-j
Copy link
Collaborator

chrismarget-j commented Jul 15, 2024

I think we should rename service_name to name in the apstra_telemetry_service_registry_entry resource and data source.

Reasons:

  1. "service" is redundant. It's already a service registry entry.
  2. The GUI uses both service name and name for this attribute, so it's not clear that one is preferred over the other.
  3. name is consistent with our other resources.
  4. The resource doesn't have an id attribute. With neither an id nor name attribute, Terraform's ObjectValueId() function won't find any identifier to use in user-facing output for this resource.
@rajagopalans
Copy link
Collaborator

I am fine with this. I didn't have a strong opinion, so I just used what was in the API.

@rajagopalans
Copy link
Collaborator

closed by #725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants