Skip to content

Commit

Permalink
Merge remote-tracking branch 'Stranger6667/dd/cache-ref-resolving'
Browse files Browse the repository at this point in the history
* Stranger6667/dd/cache-ref-resolving:
  docs: Update changelog
  perf: Replace the `Validator.evolve` method with an equivalent class attribute
  perf: Use cached lookups for resolving fragments if the referent document is known
  perf: Cache reference lookups for subschemas
  • Loading branch information
Julian committed Dec 17, 2021
2 parents 0878727 + 251763a commit d5c4d07
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 12 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ v4.3.0

* Fix undesired fallback to brute force container uniqueness check on
certain input types (#893)
* Resolving refs has had performance improvements (#893)
* Implement a PEP544 Protocol for validator classes (#890)

v4.2.1
Expand Down
46 changes: 34 additions & 12 deletions jsonschema/validators.py
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ class Validator:
schema = attr.ib(repr=reprlib.repr)
resolver = attr.ib(default=None, repr=False)
format_checker = attr.ib(default=None)
evolve = attr.evolve

def __attrs_post_init__(self):
if self.resolver is None:
Expand All @@ -182,9 +183,6 @@ def check_schema(cls, schema):
for error in cls(cls.META_SCHEMA).iter_errors(schema):
raise exceptions.SchemaError.create_from(error)

def evolve(self, **kwargs):
return attr.evolve(self, **kwargs)

def iter_errors(self, instance, _schema=None):
if _schema is not None:
warnings.warn(
Expand Down Expand Up @@ -757,6 +755,10 @@ def resolving(self, ref):
finally:
self.pop_scope()

@lru_cache()
def _find_in_referrer(self, key):
return list(self._finditem(self.referrer, key))

def _finditem(self, schema, key):
values = deque([schema])
while values:
Expand All @@ -767,22 +769,35 @@ def _finditem(self, schema, key):
yield each
values.extendleft(each.values())

def resolve(self, ref):
"""
Resolve the given reference.
"""
url = self._urljoin_cache(self.resolution_scope, ref).rstrip("/")
@lru_cache()
def _find_subschemas(self):
return list(self._finditem(self.referrer, "$id"))

@lru_cache()
def _find_in_subschemas(self, url):
subschemas = self._find_subschemas()
if not subschemas:
return None
uri, fragment = urldefrag(url)

for subschema in self._finditem(self.referrer, "$id"):
for subschema in subschemas:
target_uri = self._urljoin_cache(
self.resolution_scope, subschema["$id"],
)
if target_uri.rstrip("/") == uri.rstrip("/"):
if fragment:
subschema = self.resolve_fragment(subschema, fragment)
return url, subschema
return None

def resolve(self, ref):
"""
Resolve the given reference.
"""
url = self._urljoin_cache(self.resolution_scope, ref).rstrip("/")

match = self._find_in_subschemas(url)
if match is not None:
return match

return url, self._remote_cache(url)

Expand Down Expand Up @@ -821,12 +836,19 @@ def resolve_fragment(self, document, fragment):
if not fragment:
return document

if document is self.referrer:
find = self._find_in_referrer
else:

def find(key):
return self._finditem(document, key)

for keyword in ["$anchor", "$dynamicAnchor"]:
for subschema in self._finditem(document, keyword):
for subschema in find(keyword):
if fragment == subschema[keyword]:
return subschema
for keyword in ["id", "$id"]:
for subschema in self._finditem(document, keyword):
for subschema in find(keyword):
if "#" + fragment == subschema[keyword]:
return subschema

Expand Down

0 comments on commit d5c4d07

Please sign in to comment.