Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

returning Connection #56

Open
filchristou opened this issue Jul 2, 2023 · 0 comments
Open

returning Connection #56

filchristou opened this issue Jul 2, 2023 · 0 comments

Comments

@filchristou
Copy link
Collaborator

filchristou commented Jul 2, 2023

Currently remote_repl returns a connection and writes to the global _repl_client_connection.

And connect_repl doesn't return a connection but also writes to the global _repl_client_connection.

I find this behavior inconsistent. Is it necessary that connect_repl returns the ReplMaker prompt ?
In any case, I think it would be nice to also return the Connection.
This way the client can always have a way of closing the connection. (without having to access the global _repl_client_connection)
Aside from that, this could also enable handling multiple connections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant