You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently remote_repl returns a connection and writes to the global _repl_client_connection.
And connect_repl doesn't return a connection but also writes to the global _repl_client_connection.
I find this behavior inconsistent. Is it necessary that connect_repl returns the ReplMakerprompt ?
In any case, I think it would be nice to also return the Connection.
This way the client can always have a way of closing the connection. (without having to access the global _repl_client_connection)
Aside from that, this could also enable handling multiple connections.
The text was updated successfully, but these errors were encountered:
Currently
remote_repl
returns a connection and writes to the global_repl_client_connection
.And
connect_repl
doesn't return a connection but also writes to the global_repl_client_connection
.I find this behavior inconsistent. Is it necessary that
connect_repl
returns theReplMaker
prompt
?In any case, I think it would be nice to also return the
Connection
.This way the client can always have a way of closing the connection. (without having to access the global
_repl_client_connection
)Aside from that, this could also enable handling multiple connections.
The text was updated successfully, but these errors were encountered: