-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
is Mux.jl an appropriate home for HTTP/Revise glue? #135
Comments
I've gotten my baby TodoMVC.jl to work with this glue. It's not great, I still think |
I think that having Mux work with Revise is worthwhile, but I'm not totally sold on this approach. I don't really like that we're closing and re-opening the socket, either, though maybe that's fine. Re-evaluating the Looking at the revise docs, it seems like |
Awesome. We're on the same page. I don't like the opening/closing of the socket either. Frankly, there's parts of the code I don't grok.
With the existing TodoMVC, it did re-evaluate the |
I managed to use Revise with this script: using Pkg
Pkg.activate(@__DIR__)
using Revise: entr, revise
using MyApp
const t = MyApp.main() # call serve(app), nothing special
entr(String[], [MyApp]; all = true) do
revise(MyApp)
end |
Stumbling upon this because also for me it seems that revise is not working with Mux.jl which is very unfortunate... Are there any updates on makeing Revise work with Mux.jl? |
I just found a simple way: not to use I guess the advantage that Revise works out of the box like this is really huge. module MyModule
using Mux: serve, mux, App
myserve(req) = req |> mux(
...
)
function main()
serve(App(myserve), 1234)
end
end # module Looks only very slightly alien ;-) but as Revise works and we have one macro less, I am actually quite happy with it. |
Ah, yes, that's a nice simple approach! Very nice 😃 Would you be happy to make a PR adding something like this to the readme? |
@cmcaine -- would Mux.jl be a good place to have a middleware component that adds
Revise.jl
glue? See JuliaWeb/HTTP.jl#587If we're promoting
Mux.jl
as an application developer stack, having Revise functionality out-of-the-box is kinda important. For now, it's just a side script in the application I have, but it'd be better if this were shared with others.The text was updated successfully, but these errors were encountered: