-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TestEnv for subpackages: precompile only the new test Project #90
base: main
Are you sure you want to change the base?
Conversation
FYI the
definitely seems like a flakey unrelated failure |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
===========================================
- Coverage 32.10% 10.46% -21.65%
===========================================
Files 28 28
Lines 707 707
===========================================
- Hits 227 74 -153
- Misses 480 633 +153 ☔ View full report in Codecov by Sentry. |
🤔 the 1.9 / 1.10 test failures seem real:
but weirdly the tests all pass for me locally, on julia 1.9, 1.10, and 1.11 on both macos and linux... 🤔 any ideas? JULIA_PKG_SERVER_REGISTRY_PREFERENCE=eager julia +1.10 --proj --startup=no -e 'using Pkg; Pkg.test()'
...
Test Summary: | Pass Total Time
TestEnv.jl | 16 16 6.1s
Testing TestEnv tests passed |
Gonna try checking if CI is just broken due to something transient in the Pkg registry or something like that, by opening this PR: #91. |
Fixes #89.
Woohoo! :) It seems to work now! :)
@davidanthoff: This should also make testing subpackages faster in VSCode as well, not just for ReTestItems.
I'm happy to clone 1.9 into a 1.10 directory, and make this change there, but it doesn't seem to hurt anything on older versions so it seems like we can keep things as-is?