Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the badge for Aqua.jl? #119

Closed
hyrodium opened this issue May 31, 2023 · 7 comments · Fixed by #126
Closed

Update the badge for Aqua.jl? #119

hyrodium opened this issue May 31, 2023 · 7 comments · Fixed by #126

Comments

@hyrodium
Copy link
Contributor

The current badge is not consistent in appearance.
image

This can be improved from

Aqua QA

to

![](https://img.shields.io/badge/Aqua.jl-v0.6-cyan.svg?logo=data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiIHN0YW5kYWxvbmU9Im5vIj8+CjwhLS0gQ3JlYXRlZCB3aXRoIElua3NjYXBlIChodHRwOi8vd3d3Lmlua3NjYXBlLm9yZy8pIC0tPgoKPHN2ZwogICB3aWR0aD0iMTkiCiAgIGhlaWdodD0iMTQiCiAgIHZpZXdCb3g9IjAgMCA1LjAyNzA4MzIgMy43MDQxNjY4IgogICB2ZXJzaW9uPSIxLjEiCiAgIGlkPSJzdmc1IgogICBzb2RpcG9kaTpkb2NuYW1lPSJiYWRnZS5zdmciCiAgIGlua3NjYXBlOnZlcnNpb249IjEuMi4yIChiMGE4NDg2NTQxLCAyMDIyLTEyLTAxKSIKICAgeG1sbnM6aW5rc2NhcGU9Imh0dHA6Ly93d3cuaW5rc2NhcGUub3JnL25hbWVzcGFjZXMvaW5rc2NhcGUiCiAgIHhtbG5zOnNvZGlwb2RpPSJodHRwOi8vc29kaXBvZGkuc291cmNlZm9yZ2UubmV0L0RURC9zb2RpcG9kaS0wLmR0ZCIKICAgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIgogICB4bWxuczpzdmc9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIj4KICA8c29kaXBvZGk6bmFtZWR2aWV3CiAgICAgaWQ9Im5hbWVkdmlldzEzIgogICAgIHBhZ2Vjb2xvcj0iI2ZmZmZmZiIKICAgICBib3JkZXJjb2xvcj0iIzAwMDAwMCIKICAgICBib3JkZXJvcGFjaXR5PSIwLjI1IgogICAgIGlua3NjYXBlOnNob3dwYWdlc2hhZG93PSIyIgogICAgIGlua3NjYXBlOnBhZ2VvcGFjaXR5PSIwLjAiCiAgICAgaW5rc2NhcGU6cGFnZWNoZWNrZXJib2FyZD0iMCIKICAgICBpbmtzY2FwZTpkZXNrY29sb3I9IiNkMWQxZDEiCiAgICAgc2hvd2dyaWQ9ImZhbHNlIgogICAgIGlua3NjYXBlOnpvb209IjI1LjI2MjExNiIKICAgICBpbmtzY2FwZTpjeD0iOC45MDY2MTcyIgogICAgIGlua3NjYXBlOmN5PSIyLjA3ODIxMDciCiAgICAgaW5rc2NhcGU6d2luZG93LXdpZHRoPSIxNDQ0IgogICAgIGlua3NjYXBlOndpbmRvdy1oZWlnaHQ9IjEyMzYiCiAgICAgaW5rc2NhcGU6d2luZG93LXg9IjQ1MyIKICAgICBpbmtzY2FwZTp3aW5kb3cteT0iMTcyIgogICAgIGlua3NjYXBlOndpbmRvdy1tYXhpbWl6ZWQ9IjAiCiAgICAgaW5rc2NhcGU6Y3VycmVudC1sYXllcj0ic3ZnNSIgLz4KICA8ZGVmcwogICAgIGlkPSJkZWZzMiIgLz4KICA8ZWxsaXBzZQogICAgIHN0eWxlPSJmaWxsOiMzODk4MjY7ZmlsbC1vcGFjaXR5OjE7c3Ryb2tlOiNmZmZmZmY7c3Ryb2tlLXdpZHRoOjAuMztzdHJva2UtbWl0ZXJsaW1pdDo0O3N0cm9rZS1kYXNoYXJyYXk6bm9uZTtzdHJva2Utb3BhY2l0eToxIgogICAgIGlkPSJwYXRoODU0IgogICAgIGN4PSIyLjUxODg3MTEiCiAgICAgY3k9IjEuNTIzODQxOSIKICAgICByeD0iMS4zMjI5MTYyIgogICAgIHJ5PSIxLjMyMjkxNjciIC8+CiAgPGNpcmNsZQogICAgIHN0eWxlPSJmaWxsOiNjYjNjMzM7ZmlsbC1vcGFjaXR5OjE7c3Ryb2tlOiNmZmZmZmY7c3Ryb2tlLXdpZHRoOjAuMztzdHJva2UtbWl0ZXJsaW1pdDo0O3N0cm9rZS1kYXNoYXJyYXk6bm9uZTtzdHJva2Utb3BhY2l0eToxIgogICAgIGlkPSJwYXRoMTAxMDMiCiAgICAgY3g9IjEuMTUzMjQ1OCIKICAgICBjeT0iMi41ODIxNzUiCiAgICAgcj0iMC45MjA4NTc3MyIgLz4KICA8Y2lyY2xlCiAgICAgc3R5bGU9ImZpbGw6Izk1NThiMjtmaWxsLW9wYWNpdHk6MTtzdHJva2U6I2ZlZmVmZTtzdHJva2Utd2lkdGg6MC4zO3N0cm9rZS1taXRlcmxpbWl0OjQ7c3Ryb2tlLWRhc2hhcnJheTpub25lO3N0cm9rZS1vcGFjaXR5OjEiCiAgICAgaWQ9InBhdGgxMDEwMy0zIgogICAgIGN4PSIzLjg4NDQ5NjUiCiAgICAgY3k9IjIuNTgyMTc1IgogICAgIHI9IjAuOTIwODU3NzMiIC8+CiAgPGcKICAgICBpZD0ibGF5ZXIyIgogICAgIHN0eWxlPSJkaXNwbGF5Om5vbmUiCiAgICAgdHJhbnNmb3JtPSJ0cmFuc2xhdGUoMC43OTM3NTA2MykiIC8+Cjwvc3ZnPgo=)
@lgoettgens
Copy link
Collaborator

lgoettgens commented May 31, 2023

Related to #82.
I personally like the solution here.

@fingolfin
Copy link
Collaborator

Thank you, I think that's a nice improvement!

But why the v0.6, it seems somewhat arbitrary? And it needs to be updated with Aqua upgrades; so we'll need variants of the badge for each version. Otherwise, if people keep using the URL https://raw.githubusercontent.com/JuliaTesting/Aqua.jl/master/badge.svg in their READMEs, then this will show whatever is the latest version of Aqua, instead of showing whichever version is used by the package in question.

Perhaps instead it could be something that expresses "this package is using Aqua regularly / as part of its CI".
Some brain storming ideas (none particular great, but perhaps inspring to someone?):

  • Aqua
  • Aqua
  • Aqua
  • Aqua
  • Aqua

Regarding the color...

Off-topic, but: am I the only one who finds the current color for the
badge some what garish? To me, it sticks out like a sore thumb. Obviously there is
a healthy amount of taste in play here.

However, with my (borrowed) designer hat one, I notice that the other badges
are not using pure primary colors (and a good thing they do this, those pure
colors should be avoided as a general rule of thumb). Instead they use toned
down variants, so not e.g a slightly darker shade of blue and not pure
(0,0,255) RGB "blue".

The updated badge already improves the color issue quite a bit by moving the
logo away from the cyan part of the badge. But perhaps we can also tone down
the color a little bit?

How about these variants:

Current

Stable
GitHub Actions
Aqua
Codecov
Aqua QA

Manual RGB

This one already looks better to me, even though it technically uses the same extreme RGB colors; however, this might be down to the color management of my OS and browser, so it might look identical to some folks?

Stable
GitHub Actions

Codecov
Aqua QA

Toned down variant

This one reduces the amount of green and blue a little bit (away from the extreme 0xFF to 0xEE).
IMO both this and the previous color fit in much better with the other badges.

Stable
GitHub Actions

Codecov
Aqua QA

@hyrodium
Copy link
Contributor Author

hyrodium commented Jun 1, 2023

Thank you for the detailed comment!

But why the v0.6, it seems somewhat arbitrary?

I just added v0.6 as a random word because and seem boring. How about ?

Off-topic, but: am I the only one who finds the current color for the badge some what garish?

I agree with that. I guess the current color #00FFFF is used just because it is also called aqua. I think it's better to pick a color from some online pallets.

I prefer the first one, but any other colors are still great.

@fingolfin
Copy link
Collaborator

I like your proposals! And all the colors are nice, definitely nicer than pure cyan. I'd be happy to go with the first one. I'll make a PR changing this.

By the way, were did you get the SVG for the Julia balls from?

@fingolfin
Copy link
Collaborator

Oh and of course one more option would be to go with a plain badge w/o the Julia logo:

Note quite as "fun" but simpler and one could just suggest using the shields.io badge directly instead of providing a copy in the repo...

One may also question why Aqua is "entitled" to use the Julia logo in the badge... Ah well :-)

@hyrodium
Copy link
Contributor Author

hyrodium commented Jun 1, 2023

By the way, were did you get the SVG for the Julia balls from?

I have modified the original SVG file with inkscape.

One may also question why Aqua is "entitled" to use the Julia logo in the badge... Ah well :-)

The shape of this logo is different from the original Julia logo.
Perhaps its logo is based on the shape of bubbles.

badge

I'll open a PR to add this logo to the documentation page.

@hyrodium hyrodium mentioned this issue Jun 1, 2023
@hyrodium
Copy link
Contributor Author

hyrodium commented Nov 8, 2023

Perhaps its logo is based on the shape of bubbles.

I was thinking of bubbles like this image, but this was incorrect.

https://www.nsf.gov/news/mmg/mmg_disp.jsp?med_id=51415&from=

It was a water molecule.

image

https://en.wikipedia.org/wiki/Properties_of_water

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants