Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save #790

Closed
prezaei85 opened this issue Mar 26, 2015 · 3 comments
Closed

save #790

prezaei85 opened this issue Mar 26, 2015 · 3 comments

Comments

@prezaei85
Copy link

function save has a conflict with the same function in the package HDF5. As that package is basically the one to save things, should the save function here be reconsidered?

julia> using DataFrames

julia> methods(save)
#1 method for generic function "save":
save(filename::String,df::DataFrame) at /Users/prezaei/.julia/v0.3/DataFrames/src/dataframe/io.jl:989

julia> using HDF5, JLD
Warning: imported binding for DL_LOAD_PATH overwritten in module BinDeps
Warning: using JLD.save in module Main conflicts with an existing identifier.
@simonster
Copy link
Contributor

We should probably get rid of save in this package. serialize was never intended as a file format; the format changes between Julia releases; and deserialize may fail when types change.

@johnmyleswhite
Copy link
Contributor

+1 to removing save

@garborg
Copy link
Contributor

garborg commented Mar 26, 2015

Agreed.

On Thu, Mar 26, 2015 at 4:50 PM, John Myles White notifications@github.com
wrote:

+1 to removing save


Reply to this email directly or view it on GitHub
#790 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants