exported HOFs all do thunk #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some functions have a method whose final arg is a function. The do block idiom doesn't work for those methods, so alternate methods were added (exported functions with a single function arg only).
|
Going to go ahead with this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Some functions have a method whose final arg is a function.
The do block idiom doesn't work for those methods, so alternate methods
were added (exported functions with a single function arg only).
Motivations:
I expected a do block to work with
by, and added it to the rest for consistency. I've seen this done elsewhere, so I assume it's non-controversial, but I'm not sure, so feel free to contradict.