Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getrowval and getnzval are defined on SparseMatrixCSC but not on SparseVector #172

Open
rayegun opened this issue Jun 30, 2022 · 4 comments
Open

getrowval and getnzval are defined on SparseMatrixCSC but not on SparseVector #172

rayegun opened this issue Jun 30, 2022 · 4 comments

Comments

@rayegun
Copy link
Member

rayegun commented Jun 30, 2022

rowval is defined on both, but curiously getrowval is not. I'm not sure exactly why we have two identical accessor functions.
@rayegun rayegun changed the title getrowval is defined on SparseMatrixCSC but not on SparseVector getrowval and getnzval are defined on SparseMatrixCSC but not on SparseVector Jun 30, 2022
@ViralBShah
Copy link
Member

Some discussion: JuliaLang/julia#33041

@rayegun
Copy link
Member Author

rayegun commented Jul 12, 2022

It seems like those changes just rotted more than anything correct? I'll comb through them.

@ViralBShah
Copy link
Member

ViralBShah commented Jul 12, 2022 •
edited
Loading

I believe so. The main issue is to see how many packages use the APIs (whichever one we want to delete). I think you can search on juliahub.com to get a quick check.

@rayegun
Copy link
Member Author

rayegun commented Jul 13, 2022

For now I just intend to fill in the missing functions. That means we have two functions that do the same things, but we're just extending the matrix function to cover vectors as well.

Then we can put deleting one of them in a SparseArrays.jl v2.0 list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ViralBShah @rayegun