Simplify tests of views and subarrays #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #17 +/- ##
==========================================
- Coverage 99.45% 99.42% -0.03%
==========================================
Files 24 24
Lines 2367 2280 -87
==========================================
- Hits 2354 2267 -87
Misses 13 13
Continue to review full report at Codecov.
|
|
tmigot
force-pushed
the
siplify-view-test
branch
from
65d674b
to
9210bee
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two simplifications:
grad(nlp, x, gx)we only test if it works correctly whengxis a view, and not whenxis.I added
hess_coord!, which wasn't tested before.