No incrementation of neval_hprod

[paraynaud]

@dpo, I made some tests about TR-LBFGS.
The point was to check how many $Bv$ were done.
I was suprised to obtain 0 with lbfgsnlp.model.counters.neval_hprod.
I checked the code below, and there is no increment!(qnnlp, :neval_hprod) inside hprod nor hprod!.

NLPModelsModifiers.jl/src/quasi-newton.jl

Line 109 in ca5bf27

NLPModels.hprod(nlp::QuasiNewtonModel, x::AbstractVector, v::AbstractVector; kwargs...) = nlp.op * v

NLPModelsModifiers.jl/src/quasi-newton.jl

Line 120 in ca5bf27

function NLPModels.hprod!(

NLPModelsModifiers.jl/src/quasi-newton.jl

Line 127 in ca5bf27

@views mul!(Hv[1:(nlp.meta.nvar)], nlp.op, v)

However, I can retrieve the number of mul! done by the LBFGSOperator with lbfgsnlp.op.nprod.

Should I open a PR to add increment!(qnnlp, :neval_hprod) to hprod and hprod!?

[tmigot]

Good idea!

[dpo]

Yes I agree that it makes sense to count hprods for quasi-Newton models in the context of your research. Please open a PR.