Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap parametric optim for manopt and better convolution performance #1784
Swap parametric optim for manopt and better convolution performance #1784
Changes from all commits
31ce516
bbed441
f9af5ce
752dc27
2188482
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 71 in src/Factors/Circular.jl
Codecov / codecov/patch
src/Factors/Circular.jl#L71
Check warning on line 246 in src/Factors/GenericFunctions.jl
Codecov / codecov/patch
src/Factors/GenericFunctions.jl#L246
Check warning on line 303 in src/parametric/services/ParametricManopt.jl
Codecov / codecov/patch
src/parametric/services/ParametricManopt.jl#L303
Check warning on line 498 in src/parametric/services/ParametricManopt.jl
Codecov / codecov/patch
src/parametric/services/ParametricManopt.jl#L498
Check warning on line 505 in src/parametric/services/ParametricManopt.jl
Codecov / codecov/patch
src/parametric/services/ParametricManopt.jl#L505
Check warning on line 542 in src/parametric/services/ParametricManopt.jl
Codecov / codecov/patch
src/parametric/services/ParametricManopt.jl#L540-L542
Check warning on line 831 in src/parametric/services/ParametricUtils.jl
Codecov / codecov/patch
src/parametric/services/ParametricUtils.jl#L831
Check warning on line 847 in src/parametric/services/ParametricUtils.jl
Codecov / codecov/patch
src/parametric/services/ParametricUtils.jl#L847
Check warning on line 972 in src/parametric/services/ParametricUtils.jl
Codecov / codecov/patch
src/parametric/services/ParametricUtils.jl#L972
Check warning on line 981 in src/parametric/services/ParametricUtils.jl
Codecov / codecov/patch
src/parametric/services/ParametricUtils.jl#L981
Check warning on line 987 in src/parametric/services/ParametricUtils.jl
Codecov / codecov/patch
src/parametric/services/ParametricUtils.jl#L986-L987
Check warning on line 990 in src/parametric/services/ParametricUtils.jl
Codecov / codecov/patch
src/parametric/services/ParametricUtils.jl#L990