Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap parametric optim for manopt and better convolution performance #1784

Merged
merged 5 commits into from
Oct 13, 2023

Conversation

Affie
Copy link
Member

@Affie Affie commented Oct 12, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #1784 (2188482) into master (d2963ac) will decrease coverage by 22.26%.
Report is 5 commits behind head on master.
The diff coverage is 62.50%.

@@             Coverage Diff             @@
##           master    #1784       +/-   ##
===========================================
- Coverage   75.04%   52.78%   -22.26%     
===========================================
  Files          82       80        -2     
  Lines        5982     5973        -9     
===========================================
- Hits         4489     3153     -1336     
- Misses       1493     2820     +1327     
Files Coverage Δ
src/manifolds/services/ManifoldSampling.jl 61.11% <100.00%> (-27.78%) ⬇️
src/parametric/services/ParametricCSMFunctions.jl 88.63% <100.00%> (ø)
src/services/CalcFactor.jl 55.41% <100.00%> (-15.29%) ⬇️
src/services/NumericalCalculations.jl 36.64% <100.00%> (-32.83%) ⬇️
src/services/VariableStatistics.jl 88.88% <100.00%> (+13.88%) ⬆️
src/Factors/Circular.jl 71.87% <50.00%> (ø)
src/Factors/GenericFunctions.jl 10.66% <0.00%> (-45.75%) ⬇️
src/parametric/services/ParametricManopt.jl 85.11% <62.50%> (+32.20%) ⬆️
src/parametric/services/ParametricUtils.jl 66.89% <12.50%> (-3.94%) ⬇️

... and 48 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Affie Affie merged commit c49e4b0 into master Oct 13, 2023
4 of 7 checks passed
@dehann dehann changed the title Swop parametric optim for manopt and better convolution performance Swap parametric optim for manopt and better convolution performance Oct 22, 2023
@Affie Affie deleted the 23Q4/parametric/swap_solver branch May 6, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants