Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup calcCovarianceBasic #1643

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Cleanup calcCovarianceBasic #1643

merged 1 commit into from
Dec 15, 2022

Conversation

Affie
Copy link
Member

@Affie Affie commented Dec 11, 2022

No description provided.

@Affie Affie self-assigned this Dec 11, 2022
@Affie Affie added this to the v0.31.1 milestone Dec 11, 2022
@Affie Affie force-pushed the 22Q4/depr/rm_calcCovarianceBasic branch from bed05ad to f6da52b Compare December 11, 2022 14:17
@Affie Affie force-pushed the 22Q4/depr/rm_calcCovarianceBasic branch from f6da52b to 2946255 Compare December 11, 2022 15:57
@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Merging #1643 (2946255) into master (0a0c68b) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1643      +/-   ##
==========================================
- Coverage   67.43%   67.41%   -0.02%     
==========================================
  Files          72       72              
  Lines        5592     5592              
==========================================
- Hits         3771     3770       -1     
- Misses       1821     1822       +1     
Impacted Files Coverage Δ
src/VariableStatistics.jl 76.47% <ø> (ø)
src/services/EvalFactor.jl 80.41% <ø> (ø)
src/ParametricUtils.jl 47.53% <0.00%> (-0.26%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Affie
Copy link
Member Author

Affie commented Dec 15, 2022

I think test failure is not related to this PR and there might have been a regression somewhere.

@Affie Affie merged commit 9685c9d into master Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant