Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solveGraphParametric returns points on manifold #1568

Merged
merged 12 commits into from
Aug 5, 2022

Conversation

Affie
Copy link
Member

@Affie Affie commented Jul 18, 2022

Make sure it is consistent everywhere. It was coordinates in updateGraphParametric and points in tree solve.
Should also add tests.

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #1568 (f65579e) into master (167c964) will decrease coverage by 0.06%.
The diff coverage is 59.70%.

@@            Coverage Diff             @@
##           master    #1568      +/-   ##
==========================================
- Coverage   77.68%   77.62%   -0.07%     
==========================================
  Files          71       71              
  Lines        5095     5099       +4     
==========================================
  Hits         3958     3958              
- Misses       1137     1141       +4     
Impacted Files Coverage Δ
src/Deprecated.jl 0.00% <0.00%> (ø)
src/ParametricCSMFunctions.jl 88.60% <ø> (ø)
src/ManifoldsExtentions.jl 67.85% <87.50%> (-0.15%) ⬇️
src/ParametricUtils.jl 70.69% <89.18%> (+4.03%) ⬆️
src/Factors/Circular.jl 71.42% <0.00%> (-3.58%) ⬇️
src/SolverUtilities.jl 43.28% <0.00%> (-1.50%) ⬇️
src/SolveTree.jl 95.83% <0.00%> (-1.39%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Affie
Copy link
Member Author

Affie commented Jul 25, 2022

I suspect something upstream might have broken tests as tests are failing that are unrelated to this PR.

@dehann
Copy link
Member

dehann commented Jul 25, 2022

Think it might be timing out, there are tons of printouts, e.g.:

┌ Warning: H
│   z =1×1 Matrix{Float64}:2.2280376589546504
│   x1 =1-element Vector{Float64}:-2.27696645737917
│   x2 =1-element Vector{Float64}:-0.04892879844156184
└ @ IncrementalInference ~/work/IncrementalInference.jl/IncrementalInference.jl/src/Factors/LinearRelative.jl:41

@dehann
Copy link
Member

dehann commented Jul 26, 2022

@Affie Affie modified the milestones: v0.30.1, v0.30.2 Jul 28, 2022
@dehann dehann modified the milestones: v0.30.2, v0.30.3 Jul 29, 2022
@Affie Affie self-assigned this Aug 4, 2022
@Affie Affie marked this pull request as ready for review August 4, 2022 22:45
@Affie Affie merged commit 6ccc934 into master Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants