Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCW.threadmodel for a factor is not persisted with save/loadfg #1194

Closed
Affie opened this issue Feb 26, 2021 · 2 comments
Closed

CCW.threadmodel for a factor is not persisted with save/loadfg #1194

Affie opened this issue Feb 26, 2021 · 2 comments
Assignees
@dehann
Labels
API dfg factors multithreading potential bug refactoring serialization upstream
Milestone
v0.32.0

Comments

@Affie
Copy link
Member

Affie commented Feb 26, 2021

Just noting it here, probably part of CCW, CPT, FMd, CF CFM make-over.
@Affie Affie added this to the v0.x.0 milestone Feb 26, 2021
@dehann
Copy link
Member

dehann commented Mar 10, 2021

Perhaps we should rather make this part of the factor definition and more permanent if we able to confirm computational benefits from memory etc?

Think user should still have "backdoor" access to disable multithreading in case there is some kind of debugging required, or desire to test otherwise.

@dehann dehann modified the milestones: v0.x.0, v0.32.0 Jan 2, 2023
@dehann
Copy link
Member

dehann commented Jan 2, 2023

threadmodel was removed from CCW and is now obsolete, so no point in storing it.

@dehann dehann closed this as completed Jan 2, 2023
@dehann dehann self-assigned this Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dehann dehann

Labels
API dfg factors multithreading potential bug refactoring serialization upstream
Projects
None yet
Milestone
v0.32.0
Development

No branches or pull requests
2 participants
@dehann @Affie