Plots don't show automatically when PyPlot compiled with PackageCompiler #476
Comments
|
Looks like the error goes away after upgrading matplotlib 3.1.1 -> 3.2.1 (as per #459 (comment)). The plot still is not showing automatically though. Any way to reset whatever has gone wrong to make them show? |
|
Hey @marius311, this happens because using PyPlot
PyPlot.isjulia_displayPyPlot sets this global when it runs its init, which I suppose has now been compiled into your sysimage. Line 178 in c451315 This kind of thing should happen to any PackageCompiler-ed package which relies on logic during package loading. You can manually I'll see if I can make a PR. |
|
Probably all it takes is just to check if there are displays whenever a cell is requested. For example, this works in a sysimage, using PyCall
using PyPlot
function display_figs() # called after IJulia cell executes
if PyPlot.isdisplayok() # CHANGED FROM QUERYING GLOBAL
for manager in PyPlot.Gcf."get_all_fig_managers"()
f = manager."canvas"."figure"
if f.number ∉ PyPlot.withfig_fignums
fig = Figure(f)
isempty(fig) || display(fig)
pycall(plt."close", PyAny, f)
end
end
end
end
plt.plot()
display_figs()One also needs to push the pre-executes (which don't seem to make it in the sysimage) Main.IJulia.push_preexecute_hook(PyPlot.force_new_fig)
Main.IJulia.push_postexecute_hook(PyPlot.display_figs)
Main.IJulia.push_posterror_hook(PyPlot.close_figs) |
|
Thanks, yea I think you're on the right track. The thing is that PackageCompiler still runs
|
|
I'm afraid that's going to mess up other aspects of the initialization, too. In particular, if a Julia display is detected when PyPlot is initialized, then it starts up Matplotlib in non-interactive mode, so that figures are only displayed when the cell finishes executing and the post-execute hook is called. Whereas if Why is |
As you described in the PR, the best way to fix this is probably to do things in a lazy fashion within PyPlot. Here's an example of the order of init calls changing when using sysimages. Consider the following test where I just stick a print statement in the PyPlot init. normal orderwith sysimageWith the sysimage, PyPlot's init is called before the first line of Julia code is started. Presumably PyPlot wakes up and runs init, only to find a barren land without any IJulia loaded. I'd be interested in reading how Julia starts up, maybe it's in the docs. |
|
My current solution is calling a custom function This function simply sets This doesn't fix the fact that a GUI event loop is, presumably, unnecesarily spun up.
`autodisplay_figs()`:"""
When using a sysimg with PyPlot in it, PyPlot's `__init__` gets called before IJulia is
initialized. As a result, figures do not get automatically displayed in the notebook.
(https://github.com/JuliaPy/PyPlot.jl/issues/476).
Calling `autodisplay_figs()` after IJulia is initialized fixes that.
"""
function autodisplay_figs()
if (isdefined(Main, :PyPlot) && isdefined(Main, :IJulia) && Main.IJulia.inited
&& (Main.PyPlot.isjulia_display[] == false)
)
Main.PyPlot.isjulia_display[] = true
Main.IJulia.push_preexecute_hook(Main.PyPlot.force_new_fig)
Main.IJulia.push_postexecute_hook(Main.PyPlot.display_figs)
Main.IJulia.push_posterror_hook(Main.PyPlot.close_figs)
end
end |
|
See also my #480 (comment) on how I think this should be fixed. |
|
The following command works for me as a workaround when using the REPL: |
Not sure if this is supposed to work (in any case it seems like its really close to working). I compiled PyPlot v2.8.2 with PackageCompiler v1.1.0 on julia 1.4,
then load it with
Any ideas if this can work and if so how? Thanks.
The text was updated successfully, but these errors were encountered: